-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: useCachedQueryProvider to ensure required data is loaded for rendering #2940
Conversation
🚀 Deployed on https://pr-2940--dhis2-maps.netlify.app |
2 flaky tests on run #2635 ↗︎
Details:
layers/thematiclayer.cy.js • 1 flaky test • e2e-chrome-parallel-2.40
dataDownload.cy.js • 1 flaky test • e2e-chrome-parallel-2.40
Review all test suite changes for PR #2940 ↗︎ |
87cfb56
to
3b5c6fa
Compare
…lem with jest tests
f92133c
to
72a1b04
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Approved with two small comments.
I've tested the Maps app without finding any issues. I have not tested the plugin, but the code changes looks fine to me.
🎉 This PR is included in version 100.2.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
By using the CachedQueryProvider we get the following benefits:
loading
status is handled so maps components don't need to check if systemSettings or userSettings are loadedNotes:
nameProperty
comes from the CachedQueryProvider instead of the User/SystemSettingsProviderThis work is being done now to simplify implementing the routing